My vote-
(I can't get no) Satisfaction
https://youtu.be/OZ8GZ3PFVGM
Keith Richards was asked how he came up with the unique riff, said he woke up from a dream, wrote down the chords, and went back to sleep... when he woke up he had forgotten all about it...like finding gold.
https://www.youtube.com/watch?v=Gbfnh1oVTk0
rocket 88 for sure
I love Molly Hatchett's riff on Dreams I'll Never See:
https://www.youtube.com/watch?v=jTZHHQplIX8
I don't know about from all time, but I heard professional widow by tori Amos for the first time in years today and that is a great bass riff. I wish it was instrumental tbh 🎶
shareCream - Sunshine of Your Love
https://www.youtube.com/watch?v=zt51rITH3EA
Lenny Kravitz - Are you gonna go my way?
It's not great from guitarists' perspective, but it's simple and effective. Makes me tap my toes every time!
[deleted]
Nirvana- Smells like teen spirit. I know the main riff is supposed to be a rip-off of Boston´s more than a feeling but I think its better. So simple yet so powerful. Cream is a good pick too. Someone mentioned Mark Knopfler. Undoubtedly one of the greatest guitarists ever but I think he was more well known for his solos then riffs.
shareA few that come to mind:
You Really Got Me - The Kinks
Layla - Derek and the Dominos
Supermassive Black Hole - Muse
Superstition - Stevie Wonder
Song 2 - Blur
My Sharona - The Knanck
Voodoo Child - Jimi Hendrix
Sweet Child O Mine - Guns'N'Roses
Play That Funky Music - Wild Cherry