It's a nice looking movie, but the plot is really lame.
I don't get why does Louis Cyphre go to the trouble of sending Harry Angel on a wild goose chase when Cyphre obviously knows he's Johnny Favorite. Harry doesn't remember he's Johnny Favorite because of a medical condition and not because of a soul stealing ritual, so that wouldn't be the reason. If he's so mad at Johnny for trying to trick him, then just kill him like he did the lawyer and take his soul if he doesn't want to wait for him to die naturally.
The whole selling of a soul is kind of silly. I'm sure Johnny Favorite's soul was damned before he even sold it.