Filmed in Vancouver but does it actually take place there? Vancouver always stands in for different cities.
shareNew York. X-Men live in there.
------------------------------------->
The X-Men timeline was altered 2 times, not just one (DOFP).
FIRST CLASS was already a "divergence".
Everything is explained here:
THE X-MEN CINEMATIC TIMELINES
http://x-continuity.blogspot.com
The school is in Westchester, which I think is in NY state. I am not American so I am not sure, but I think it is set in NYC.
shareAlmost every superhero Marvel has lives in New York.
shareVancouver always stands in for different cities.In this case, it doesn't have to. The X-Jet has hypersonic capabilities, so the Xavier Academy could be in Ontario, New England, New York, Pennsylvania, Ohio or Michigan, judging from the looks, whilst the nearest Weapon X program site is somewhere north of the school. share