One small gripe that always bothered me about the ending...
It's a small gripe with the Constantine universe, but it's there. So, towards the end, Constantine slits his wrists in order to make time stop, so he could get the Devil to stop his son from being born... That's all good, but the problem is, when he dies and starts ascending to Heaven, Lucifer grabs him, reaches inside and pulls out all the cancerous tumors, which is great for John, except for one thing... Lucifer (at least on screen) was not shown to heal his wrist wounds (which is how he was able to kill himself the second time)... So even if "Lu" reached in and took out all his cancer, dude had still bled to death from his self-inflicted cuts. I mean, one could "imagine" i guess that while he reached in to pull out the cancer, he also fixed John's wrists (and, u know.. put all his blood back in him :-P )... But it's never shown, nor really implied. So... It's really a plot hole to the ending, if even just a little.
Loved the movie... It just struck me as odd that the filmmakers didn't resolve this little inconsistency in the film. But hey, I guess we can't all be perfect, right? :-P (myself included ;-) )