portugal

The scenes that you mencioned they're in lisboa in a place called largo das portas do sol, near castelo s. jorge.
take the tram 28 ,i think you'll enjoy it very much.
everybody knows where it is.
take care. Hugo

In scenes from the British embassy they look across at the Cathedral (See) in the distance and the Castelo S. Jorge is just to the left out of the picture. This suggests they are in the Barrio Alto looking across the Baixa to the hill to the east. I don't know where the British Embassy actually is, and whether the Barrio Alto is an Embassy neighborhood (?).

In the embassy roof scenes, however, I think they're looking from a differnt place--probably a building near the Castelo, looking north toward the white church (don't remember the name) that is north of the Castelo.

In the scenes looking out from Barley's flat, the cathedral towers are very close by and it looks like he's on the sourthern end of the Afama district, perhaps the street/neighborhood Largo das Portas do Sol that Hugolx mentions (?). In fact his neighborhood is what they look toward in the Embassy scenes. When he's walking up a steep hill toward his flat, and IIRC, the yellow street car/tram passes, this looks like the streets in Afama so it would be accurate for the view from his flat. There is a street car route and tracks straight up the hill toward the cathedral.

Where he meets the ship it looks like the docks east of the Placa Commerical so it would be the docks he looks down on from his flat window from Afama, which would fit nicely with his story of choosing the flat ("so I could watch the ships come in").

The scenes in Lisbon are beautifully done and show something of that beautiful city. It's interesting how this film captures Moskow so well, but then also suggests the character of Lisbon too. Lisbon functions, sort of, as the place where you go when you've betrayed your country, when M. Phieffer is now your country, where you can live in civilization without the grey suits of war and the business of war so criticized in the film. Of course Portugal has its own grey suits, and a long history of imperialism of its own. But Lisbon does have sort of a tradition of refuge in that Portugal was neutral during WWII, and Lisbon was a place refugees from the big powers waited out the war, or laid over trying to get somewhere else when visas come through, etc. Sort of like Casablanca city worked in WWII, as shown in the eponymous movie. No accident there as Lisbon and Casablanca have a long history together.